Views: 2,891,417
Main | FAQ | IRC chat | Memberlist | Active users | Latest posts | Calendar | Stats | Graphs | Ranks | Online users | Search
09-24-17 04:48 AM
Guest: Register | Login

0 users currently in General Forum | 1 guest | 1 bot

Main - General Forum - I Forced a Merge


GamingG
Posted on 10-26-15 05:47 PM Link | Reply | ID: 910
Root Administrator

Cheep-cheep

Level: 25

Posts: 142/180
EXP: 84407
Next: 5213

Since: 05-21-14

Last post: 57 days
Last view: 4 days


Image upload works again.

GamingG
Posted on 10-26-15 06:43 PM Link | Reply | ID: 911
Root Administrator

Cheep-cheep

Level: 25

Posts: 143/180
EXP: 84407
Next: 5213

Since: 05-21-14

Last post: 57 days
Last view: 4 days
Private Messages and Online Users stopped working for some reason. I'll get on that.

Nightmare Fredbear
Posted on 10-26-15 06:56 PM (rev. 2 of 10-26-15 06:57 PM by Nightmare Fredbear) Link | Reply | ID: 912

Micro-Goomba

Level: 9

Posts: 13/19
EXP: 2281
Next: 881

Since: 08-27-15
From: Internet Creepypasta

Last post: 655 days
Last view: 489 days
Fix'd. It was an unquoted MySQL function. I just need to push it.

Edit: Fuck you, magic_quotes. Ugh, guess stripslashes'll have to be used.

____________________
He will come back, he always does.

Was it me?

GamingG
Posted on 10-26-15 07:03 PM (rev. 2 of 10-26-15 07:03 PM by GamingG) Link | Reply | ID: 913
Root Administrator

Cheep-cheep

Level: 25

Posts: 144/180
EXP: 84407
Next: 5213

Since: 05-21-14

Last post: 57 days
Last view: 4 days
Posted by Nightmare Fredbear
Fix\'d. It was an unquoted MySQL function. I just need to push it.

Edit: Fuck you, magic_quotes. Ugh, guess stripslashes'll have to be used.

Online users was my fault. Fixed now.

I found an issue with a WHERE clause being before a JOIN, but I think you saw that on bitbucket.

Private messages isn't working because I don't have a function named UNIX_TIMESTAMP. Should I have this function?

Also, want me to help with your repo? I could find and fix bugs whenever I have time.

EDIT: The backslashes have ascended. No one is safe.

Nightmare Fredbear
Posted on 10-26-15 07:20 PM Link | Reply | ID: 914

Micro-Goomba

Level: 9

Posts: 14/19
EXP: 2281
Next: 881

Since: 08-27-15
From: Internet Creepypasta

Last post: 655 days
Last view: 489 days
UNIX_TIMESTAMP is a MySQL function. It was my fault for not putting it quotes. The WHERE before JOIN issue was caused by staging only certain lines on git and it went past my eyes.

You can feel free to search for any bugs. I currently have rss.php on stash as I cannot really test it until I get off my ass and get an RSS client :P and I have thread.php on stash as I'm currently fixing some changes I did on my local repo.

____________________
He will come back, he always does.

Was it me?

GamingG
Posted on 10-26-15 07:30 PM Link | Reply | ID: 915
Root Administrator

Cheep-cheep

Level: 25

Posts: 145/180
EXP: 84407
Next: 5213

Since: 05-21-14

Last post: 57 days
Last view: 4 days
I fixed PMs and sent you one.

kapifurope
Posted on 11-18-15 03:19 PM Link | Reply | ID: 923

Micro-Goomba

Level: 7

Posts: 6/12
EXP: 1140
Next: 308

Since: 09-03-15

Last post: 585 days
Last view: 583 days
https://bitbucket.org/SquidEmpress/acmlmboard-2/commits/eca005ef850b7d13ae7ec57e9014be92441ee446


and you expect that to work... how??


("UNIX_TIMESTAMP()" - 30)

you are basically subtracting an int from a string

if this code yields the desired effect, I'll eat my fucking self

Nightmare Fredbear
Posted on 11-18-15 08:17 PM Link | Reply | ID: 924

Micro-Goomba

Level: 9

Posts: 16/19
EXP: 2281
Next: 881

Since: 08-27-15
From: Internet Creepypasta

Last post: 655 days
Last view: 489 days
Thanks for pointing that out.

https://bitbucket.org/SquidEmpress/acmlmboard-2/commits/91c9a28bb50f0060b30ac307672b7f9cf587c13d

____________________
He will come back, he always does.

Was it me?

kapifurope
Posted on 11-18-15 08:47 PM Link | Reply | ID: 925

Micro-Goomba

Level: 7

Posts: 7/12
EXP: 1140
Next: 308

Since: 09-03-15

Last post: 585 days
Last view: 583 days
yep, better


there are quite a few more cases like that, though



honestly, do you even test your code?

Nightmare Fredbear
Posted on 11-18-15 09:19 PM (rev. 2 of 11-18-15 09:44 PM by Nightmare Fredbear) Link | Reply | ID: 926

Micro-Goomba

Level: 9

Posts: 17/19
EXP: 2281
Next: 881

Since: 08-27-15
From: Internet Creepypasta

Last post: 655 days
Last view: 489 days
Posted by kapifurope
yep, better


there are quite a few more cases like that, though



honestly, do you even test your code?


As a matter of fact, I actually do. Hell, Id say I test around 95%. (And that 5% ends up being the ones that cause the most issues.) :P

But before I removed the magic_quotes dependence, I tested the shit out of it to make sure all dynamic queries were prepared and SQL injection was impossible.

And deeerrp. It's almost every single instance with those cases. I'll fix those shortly.
Alright. It should all be fixed now.



____________________
He will come back, he always does.

Was it me?

ahassaan
(post deleted) ID: 1263

Main - General Forum - I Forced a Merge


Acmlmboard v2.5.3pre Development (4/13/2016)
© 2005-2016 Acmlm, Emuz, et al.

Page rendered in 0.042 seconds. (1178KB of memory used)
MySQL - queries: 42, rows: 451/460, time: 0.022 seconds.